xfs
[Top] [All Lists]

Re: [PATCH 0/6] xfsprogs: more CRC support patches

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/6] xfsprogs: more CRC support patches
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Mon, 20 May 2013 12:11:44 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=xsBNWQ+rsZama5mDQmDKm4cxLZCtUvHx1PoMUMglD6A=; b=HVB4vlUiNmQIo7AWyk6jLmmPUGjrCdrlZCgXzXeMViBuaSFwTyrzhpq2itK29YPxNp wDxTUFG9tbSK1C+sQ343NjGqwRG6teReTO3b2/+GTVTEe+/1WiMV2NM4SuiBGdWF+0WC EaiP9Q12Z/q1RHF4GaWI8fNL2gvx3YJaj6gnEGBVNaqtzHiBShQOFilsbPFCAN81o8FE g77MH3zE1yiZ7qvx/YJS+pFxWNNryMiVzB2LVunedLkeBPPdKv+629ZQgkkuF+HztuQT NSvAAywnHoqAFGBqhGaxUlx2JjrcWqJbT+kubDkZT+oFmizha3rm/6YnkJQgJSN1gknp heXg==
In-reply-to: <1369032783-24973-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1368789205-19969-1-git-send-email-david@xxxxxxxxxxxxx> <1369032783-24973-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 05/20/2013 02:52 AM, Dave Chinner wrote:
[ well, really patches 31..36 :) ]

Hi folks,

More work on top of the original series of 30 patches, including
xfs_db support for parsing the v3 directory format.

Note that there are also two patches in here that convert both
xfs_db and xfs_repair to use the libxfs directory block type
definitions. While it may have once been convenient for them to have
a basic definition, it does not lend itself to making the code
support the v3 format quickly and concisely. Reusing the
libxfs/kernel structure definitions and abstraction means that the
code quickly becomes v3 aware and has just works.

Right now this patchset and the current kernel patchset (all the
attr fixes) runs through xfstests quite far on a 4k block size
filesystem - all the generic tests pass, and most of the XFS
specific tests that don't rely on write or attr output support in
xfs_db also pass.

I'll get the attr db support done tomorrow.....

Cheers,

Dave.

This makes some improvement to the setup here: xfs/041 no longer triggers a sure-fire "args->op_flags & XFS_DA_OP_OKNOENT" assertion. This will take a re-review on my part of the xfs/[0-9][0-9][0-9] test set.

Here's how the `git am` session went, syntax removed because Ctrl-w word removal in bash makes the script output unworkable:

# PATCH 1
Applying: xfs_repair: always use incore header for directory block checks
# PATCH 2
Applying: xfs_db: convert directory parsing to use libxfs structure
/usr/src/xfs/xfsprogs/.git/rebase-apply/patch:94: trailing whitespace.
        if (be32_to_cpu(data->magic) == XFS_DIR2_BLOCK_MAGIC &&
warning: 1 line adds whitespace errors.
# PATCH 3
Applying: xfs_db: factor some common dir2 field parsing code.
# PATCH 4
Applying: xfs_db: update field printing for dir crc format changes.
# PATCH 5
Applying: xfs_repair: convert directory parsing to use libxfs structure
# PATCH 6
Applying: xfs_repair: make directory freespace table CRC format aware.

Nice job!

Michael

<Prev in Thread] Current Thread [Next in Thread>