xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: check falloc in 285

To: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: check falloc in 285
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 17 May 2013 07:18:03 -0500
Cc: <xfs@xxxxxxxxxxx>, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1368351729-17778-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1368351729-17778-1-git-send-email-wenqing.lz@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 05/12/2013 04:42 AM, Zheng Liu wrote:
From: Zheng Liu <wenqing.lz@xxxxxxxxxx>

As linux 3.8, ext4 has supported the seek data/hole operation for
extent-based file and indirect-based file.  But for indirect-based file
it can not support the fallocate(2).  This causes test 285 to fail since
it assumes that all file systems which supports seek data/hole also
support fallocate.  So here we need to check it.

Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
Cc: Rich Johnston <rjohnston@xxxxxxx>
---
  tests/generic/285 | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tests/generic/285 b/tests/generic/285
index 22b4a08..d1a1baa 100644
--- a/tests/generic/285
+++ b/tests/generic/285
@@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
  _supported_fs generic
  _supported_os Linux

+_require_xfs_io_falloc
+
  BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile

  [ -x $here/src/seek_sanity_test ] || _notrun "seek_sanitfy_tester not built"


Looks good.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>