xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 311: fsck the dmflakey device instead of the real

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: 311: fsck the dmflakey device instead of the real device V2
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 17 May 2013 07:00:32 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130516203035.GE1765@xxxxxxxxxxxxxxxxxxxxx>
References: <1368631217-15511-1-git-send-email-jbacik@xxxxxxxxxxxx> <5194E764.6030207@xxxxxxx> <20130516203035.GE1765@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 05/16/2013 03:30 PM, Josef Bacik wrote:
On Thu, May 16, 2013 at 08:04:20AM -0600, Rich Johnston wrote:
On 05/15/2013 10:20 AM, Josef Bacik wrote:
Dave pointed out that xfs was having issues with 311 because of caching issues.
He suggested that I fsck the dm-flakey device to make sure we don't have this
problem.  Make _check_scratch_fs take an optional argument to use as the device
to fsck.  Thanks,

Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
---
Hi Josef,

Looks like it fails test 19 , are we supposed to see failures for ext4
and xfs?


Yeah that's what I was seeing, if you run the fsync tester without the reboot
option and look at the file itself it should match the md5sum thats in the good
output.  Thanks,

Josef

Looks good.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>