xfs
[Top] [All Lists]

Re: [patch] xfs: bug widening binary "not" operation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [patch] xfs: bug widening binary "not" operation
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 17 May 2013 09:31:59 +0300
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130516230314.GH24635@dastard>
References: <20130516075330.GB7494@xxxxxxxxxxxxxx> <20130516230314.GH24635@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 17, 2013 at 09:03:14AM +1000, Dave Chinner wrote:
> As it is, the static checker missed the:
> 
>       rounding = max_t(uint, ....);
> 
> The line before the above usage. I posted a patch to fix this this
> 2 weeks ago here:
> 
> http://oss.sgi.com/pipermail/xfs/2013-May/025986.html
> 

Ah.  Grand.  There is still a problem with the max_t().  The shift
operation will wrap before we do the cast.  It should be:

-       rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
+       rounding = max_t(xfs_off_t, 1ULL << mp->m_sb.sb_blocklog, 
PAGE_CACHE_SIZE);

regards,
dan carpenter

<Prev in Thread] Current Thread [Next in Thread>