On 05/08/2013 08:21 PM, Dave Chinner wrote:
From: Dave Chinner <dchinner@xxxxxxxxxx>
Serenity lost.
Insanity looms darkly.
/etc/mtab
Random behaviour.
xfs/189 fails
After a week passing.
-SCRATCH_DEV on SCRATCH_MNT type xfs (ro,filestreams)
+SCRATCH_DEV on SCRATCH_MNT type xfs
(ro,relatime,attr2,filestreams,inode64,noquota)
Confusion prevails.
/proc/mounts can never give success.
Anything but golden.
ls -l
/etc/mtab shows:
lrwxrwxrwx 1 root root 12 May 8 16:05 /etc/mtab -> /proc/mounts
symlink modified.
Stealth. Deception. WTF?
Ninjas go unseen.
"git grep mtab". Yay!
generic/235: sad
SElinux hack.
Remount context grot.
Mount uses all options from
/etc/mtab
Kernel rejects mount.
sed hacks /etc/mtab
Symlink becomes file.
Test frobulation.
xfs/189 passes
Randomness tamed.
Double face-palm. Tears.
Crack-inspired insanity.
mount(8) needs fixing.
Schizophrenia.
/etc/mtab. Same thing.
Test psychiatry.
Hack, slash, glue, polish.
xfs/189 fixed.
Made shiny again.
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
Thanks for the cleanup patches. Only comment is although I enjoy the
humorous patch description, can we make it shorter?
Other than that, looks good.
Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>
--Rich
|