xfs
[Top] [All Lists]

Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based fil

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based file
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Thu, 16 May 2013 11:57:58 +0800
Cc: xfs@xxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Rich Johnston <rjohnston@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=wA4xVpcl862Ocr9XwqR26I7y2/8McZPQ7RgjMLc63Z8=; b=T6SBUU95yTgcLkh7NBJnCubvDXTnXdRxCAhmJD1Bgi5Rag3KZhZMBLkg6o/8YITrTX RCqGolHrgo3VDtS+f+vhG5nIQCeyV+Ftg0dc0IT6dK46FZaR2mwrWwtLdNQlgOcKuA9l tvS5FAd0kyFj0COyVDCoalG6aO0o07TB6odPd/BuAt8TMcOwcmTFzILHXPuODH7pOfee 3n7dAJEHCkcWcuDZ0a4g0P7+YdHrqJi374ONhzfwueE/sgeg48qhH1jCiFslC9kJH33R gDoaI61VR4cUV48fcGvp0hsp7IdKb2XN4DCxpH2f41lHMEkmHHNSW45U+U8l78e0m5Uq f/bw==
In-reply-to: <5193AA69.7050507@xxxxxxxxxxx>
References: <1368463235-14478-1-git-send-email-wenqing.lz@xxxxxxxxxx> <5193AA69.7050507@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 15, 2013 at 10:31:53AM -0500, Eric Sandeen wrote:
> On 5/13/13 11:40 AM, Zheng Liu wrote:
> > From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> > 
> > After applied this commit (864688d3), xfstests #255 will not test a
> > file system that cannot support fallocate(2), such as a indirect-based
> > file in ext4.  So we need to add a new generic test case to test it.
> > 
> > The difference between #255 and this test case is only to use pwrite to
> > allocate blocks.  Other filesystems should survive in this test case.
> > In the mean time, a new argument '-u' is added into _test_generic_punch
> > not to run unwritten tests.
> > 
> > Meanwhile this commit fixes a minor problem in #255 that testfile should
> > use $seq.$$ as testfile.
> > 
> > Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> > Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
> > Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> > Cc: Rich Johnston <rjohnston@xxxxxxx>
> > ---
> > changelog:
> >  * rebase against Eric's patch
> >  * remove 'prealloc" from group
> > 
> > Hi Eric,
> > 
> > I take a close look at your patch, and 'xfs_io_opt' has been removed in your
> > patch.  I am not sure whether I need to adjust my patch or not.  Please let 
> > me
> > know if I need to change it.  Currently I only remove '-F' argument from 
> > test
> > case.
> 
> xfs_io_opt was an option passed to _test_generic_punch used for "-F", as in:
> 
> _test_generic_punch -k falloc fpunch fpunch fiemap _filter_hole_fiemap 
> $testfile -F
> 
> -F is no longer needed, so I just dropped the whole thing.
> 
> I'm sorry this patch has required so much work.  :(
> 
> If you simply replace "$xfs_io_opt " with "" in this patch, it applies
> again with some fuzz.  i.e. in vim I just did:  
> 
> :%s/$xfs_io_opt //g
> 
> to fix up the patch itself.
> 
> There is also still one instance of "-F" in the context of the hunk
> in tests/generic/255 as well which causes a little fuzz.]

Hi Eric,

Thanks for pointing it out.  I have sent a newer version to the mailing
list.  Could you please review this patch?

Thanks,
                                                - Zheng

<Prev in Thread] Current Thread [Next in Thread>