xfs
[Top] [All Lists]

Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based fil

To: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Subject: Re: [PATCH v5] xfstests: add a new test case for ext4 indirect-based file
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 15 May 2013 10:31:53 -0500
Cc: xfs@xxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Rich Johnston <rjohnston@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1368463235-14478-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1368463235-14478-1-git-send-email-wenqing.lz@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 5/13/13 11:40 AM, Zheng Liu wrote:
> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> 
> After applied this commit (864688d3), xfstests #255 will not test a
> file system that cannot support fallocate(2), such as a indirect-based
> file in ext4.  So we need to add a new generic test case to test it.
> 
> The difference between #255 and this test case is only to use pwrite to
> allocate blocks.  Other filesystems should survive in this test case.
> In the mean time, a new argument '-u' is added into _test_generic_punch
> not to run unwritten tests.
> 
> Meanwhile this commit fixes a minor problem in #255 that testfile should
> use $seq.$$ as testfile.
> 
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
> Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Rich Johnston <rjohnston@xxxxxxx>
> ---
> changelog:
>  * rebase against Eric's patch
>  * remove 'prealloc" from group
> 
> Hi Eric,
> 
> I take a close look at your patch, and 'xfs_io_opt' has been removed in your
> patch.  I am not sure whether I need to adjust my patch or not.  Please let me
> know if I need to change it.  Currently I only remove '-F' argument from test
> case.

xfs_io_opt was an option passed to _test_generic_punch used for "-F", as in:

_test_generic_punch -k falloc fpunch fpunch fiemap _filter_hole_fiemap 
$testfile -F

-F is no longer needed, so I just dropped the whole thing.

I'm sorry this patch has required so much work.  :(

If you simply replace "$xfs_io_opt " with "" in this patch, it applies
again with some fuzz.  i.e. in vim I just did:  

:%s/$xfs_io_opt //g

to fix up the patch itself.

There is also still one instance of "-F" in the context of the hunk
in tests/generic/255 as well which causes a little fuzz.]

Thank you for your perseverance on this patch.  :)

-Eric

<Prev in Thread] Current Thread [Next in Thread>