xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 311: fsck the dmflakey device instead of the real

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: 311: fsck the dmflakey device instead of the real device
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 15 May 2013 07:49:08 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1368563722-23452-1-git-send-email-jbacik@xxxxxxxxxxxx>
References: <1368563722-23452-1-git-send-email-jbacik@xxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 14, 2013 at 04:35:22PM -0400, Josef Bacik wrote:
> Dave pointed out that xfs was having issues with 311 because of caching 
> issues.
> He suggested that I fsck the dm-flakey device to make sure we don't have this
> problem.  This is the easiest way I could think to accomplish this, please let
> me know if this is a bad idea.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> ---
>  tests/generic/311 |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/generic/311 b/tests/generic/311
> index 2b3b569..f11119b 100644
> --- a/tests/generic/311
> +++ b/tests/generic/311
> @@ -125,7 +125,10 @@ _run_test()
>  
>       #Unmount and fsck to make sure we got a valid fs after replay
>       _unmount_flakey
> +     tmp=$SCRATCH_DEV
> +     SCRATCH_DEV=$FLAKEY_DEV
>       _check_scratch_fs
> +     SCRATCH_DEV=$tmp
>       [ $? -ne 0 ] && _fatal "fsck failed"

I think this can be done with a pretty simple change to
_check_scratch_fs. i.e. pass the device to be checked in as a
parameter, and if the parameter is not set, have _check_scratch_fs
default to using $SCRATCH_DEV. It's a one-line change to 311, and
about 10 lines of (simple) change to _check_scratch_fs....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>