| To: | Tomas Racek <tracek@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/2] xfstests 200: remove words from output |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 13 May 2013 10:13:23 +1000 |
| Cc: | xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1368349273-23968-1-git-send-email-tracek@xxxxxxxxxx> |
| References: | <1368349273-23968-1-git-send-email-tracek@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, May 12, 2013 at 11:01:12AM +0200, Tomas Racek wrote: > Remove phrase "block device" from 200.out since mount warning message > does not use it. Yes it does: $ sudo blockdev --setro /dev/vdb $ sudo mount /dev/vdb /mnt/scratch mount: block device /dev/vdb is write-protected, mounting read-only mount: cannot mount block device /dev/vdb read-only So this change will break a currently working test.... Have you just upgraded to a new core-utils installation? Your next patch about apostrophes indicates that you probably have. If the mount error output has changed as a result of the upgrade, you need to add a filter so that both old and new versions emit the same golden output.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: change file mode, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/2] xfstests: unify apostrophes in output files, Dave Chinner |
| Previous by Thread: | Re: [PATCH 2/2] xfstests: unify apostrophes in output files, Dave Chinner |
| Next by Thread: | [PATCH v2] xfstests: add _require_seek_data_hole to check seek data/hole, Zheng Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |