Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, May 08, 2013 at 08:24:35AM -0500, Mark Tinguely wrote:
> On 05/07/13 18:54, Dave Chinner wrote:
> 
> 
> Checking the EFI for whether it is being released from recovery
> after we've already released the known active reference is a mistake
> worthy of a brown paper bag. Fix the (now) obvious use after free
> that it can cause.
> 
> Reported-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_extfree_item.c |   14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> Looks good.
> 
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

Zach pointed out that the fix is much more complex than it needs to
be. I'll respin the patch and resend it later today.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx