xfs
[Top] [All Lists]

Re: [PATCH 10/8] xfsdb: re-instate DA btree node headers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 10/8] xfsdb: re-instate DA btree node headers
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 09 May 2013 10:23:24 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130501063006.GK10481@dastard>
References: <20130430121300.GB10481@dastard> <20130501063006.GK10481@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 05/01/13 01:30, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

When removing the dirv1 code, it wasn't immediately obvious that the
dir v2 code used a small chunk of the dirv1 field definitions. i.e.
those for the DA btree node headers. Hence bits of xfs_db didn't
work as expected, and some tests failed in non-obvious ways. e.g
test 073 failed with this additional line of output:

Use of uninitialized value $logstart in numeric gt (>) at 
/home/dave/src/xfstests-dev/src/fill2fs line 84

which was the result of the command:

        xfs_db -r -c sb -c $TEST_DEV

giving an unexpectedly incorrect output.

Re-instate the needed field definitions and rename them from "DIR"
to "DA" so it is obvious they are for decoding DA Btree format
blocks.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

This no longer cleanly applies.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>