xfs
[Top] [All Lists]

Re: [PATCH 9/8] libxlog: fix log buffer alignment

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/8] libxlog: fix log buffer alignment
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 09 May 2013 10:07:17 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130501001714.GH10481@dastard>
References: <20130430121300.GB10481@dastard> <20130501001714.GH10481@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/30/13 19:17, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The libxlog sync changed the way log buffers used in recovery are
aligned to sector sizes. The old code used to check for a zero log
sector size and not do any alignment - this check was removed from
the kernel code because there is always log sector size configured.
It turns out that userspace *never* sets the log sector size, so
userspace has always simply ignored the alignment in log replay
(oops!).

This problem manifested itself as detecting a freshly mkfs'd
filesystem as having a totally zeroed log and hence xfs_check was
emitting output and hence xfstests was refusing to run.

This patch correctly configures the callers that use the log
recovery code so that the log sector size is set appropriately and
ensures that log recovery operates as expected.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 9/8] libxlog: fix log buffer alignment, Mark Tinguely <=