xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 9 May 2013 09:34:28 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <518A6325.3030809@xxxxxxxxxxx>
References: <1367993066-9313-1-git-send-email-david@xxxxxxxxxxxxx> <1367993066-9313-3-git-send-email-david@xxxxxxxxxxxxx> <518A6325.3030809@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, May 08, 2013 at 09:37:25AM -0500, Eric Sandeen wrote:
> On 5/8/13 1:04 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Realtime XFS filesystems do not support quotas, so quota tests
> > always fail on such filesystems. Add a check to _require_quota to
> > detect this situation and notrun the quota tests...
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> (PS why is USE_EXTERNAL a thing?  if it's set, shouldn't it be used?)

Because if you have rtdev/logdev defined in your config, you can
choose whether to test them or not without having to modify the
config file. Very handy, really.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>