xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: quota not supported on realtime filesystems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 08 May 2013 09:37:25 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1367993066-9313-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1367993066-9313-1-git-send-email-david@xxxxxxxxxxxxx> <1367993066-9313-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Realtime XFS filesystems do not support quotas, so quota tests
> always fail on such filesystems. Add a check to _require_quota to
> detect this situation and notrun the quota tests...
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

(PS why is USE_EXTERNAL a thing?  if it's set, shouldn't it be used?)

-Eric

> ---
>  common/quota |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/common/quota b/common/quota
> index fd5374f..3550cd4 100644
> --- a/common/quota
> +++ b/common/quota
> @@ -40,6 +40,12 @@ _require_quota()
>       if [ ! -f /proc/fs/xfs/xqmstat ]; then
>           _notrun "Installed kernel does not support XFS quotas"
>          fi
> +     if [ "$USE_EXTERNAL" = yes -a ! -z "$TEST_RTDEV" ]; then
> +         _notrun "Quotas not supported on realtime test device"
> +     fi
> +     if [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ]; then
> +         _notrun "Quotas not supported on realtime scratch device"
> +     fi
>       ;;
>      *)
>       _notrun "disk quotas not supported by this filesystem type: $FSTYP"
> 

<Prev in Thread] Current Thread [Next in Thread>