xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: fix incorrect redirect in generic/233

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: fix incorrect redirect in generic/233
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 08 May 2013 09:34:13 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1367993066-9313-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1367993066-9313-1-git-send-email-david@xxxxxxxxxxxxx> <1367993066-9313-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> generic/233 attempts to direct output to tee, but instead of using a
> pipe it uses an append operator. Hence it leaves a file named "tee"
> in the root directory of the xfstests execution path. Just direct
> the output to the $seqres.full file rather than trying to tee it
> into the test output as well.
> 
> Reported-by: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  tests/generic/233 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/233 b/tests/generic/233
> index 2b6cd2f..58b3672 100755
> --- a/tests/generic/233
> +++ b/tests/generic/233
> @@ -62,7 +62,7 @@ _fsstress()
>  -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
>  -n $count -d $out -p 7`
>  
> -     echo "fsstress $args" >> tee -a $seqres.full
> +     echo "fsstress $args" >> $seqres.full
>       if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | 
> _filter_num
>       then
>               echo "    fsstress $args returned $?"
> 

<Prev in Thread] Current Thread [Next in Thread>