xfs
[Top] [All Lists]

Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: xfs_efi_item slab corruption. (v3.9-10936-g51a26ae)
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 08 May 2013 08:24:35 -0500
Cc: Dave Jones <davej@xxxxxxxxxx>, CAI Qian <caiqian@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130507235458.GG24635@dastard>
References: <20130507190731.GA15528@xxxxxxxxxx> <518954DE.4070803@xxxxxxx> <20130507193146.GA7539@xxxxxxxxxx> <51895CD7.7040806@xxxxxxx> <20130507195954.GA8384@xxxxxxxxxx> <51895E51.2050508@xxxxxxx> <20130507202217.GA9883@xxxxxxxxxx> <518962FC.2060509@xxxxxxx> <20130507222256.GD24635@dastard> <51898400.8000900@xxxxxxx> <20130507235458.GG24635@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 05/07/13 18:54, Dave Chinner wrote:


Checking the EFI for whether it is being released from recovery
after we've already released the known active reference is a mistake
worthy of a brown paper bag. Fix the (now) obvious use after free
that it can cause.

Reported-by: Dave Jones <davej@xxxxxxxxxx>
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
 fs/xfs/xfs_extfree_item.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>