[Top] [All Lists]

Re: [PATCH V2] xfstests: automatically add -F to xfs_io on non-xfs

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests: automatically add -F to xfs_io on non-xfs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 8 May 2013 12:41:25 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5189B9DA.7010807@xxxxxxxxxxx>
References: <51850BED.6050109@xxxxxxxxxx> <5189B9DA.7010807@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, May 07, 2013 at 09:35:06PM -0500, Eric Sandeen wrote:
> The -F flag to xfs_io originally enabled it to operate on non-xfs
> filesystems.  This restriction was removed upstream in favor of
> gracefully failing on the handful of operations that actually
> required xfs, and the option was deprecated.
> However, xfstests is still used on distros with older xfsprogs, and
> so "xfs_io -F" was necessary throughout xfstests.
> Simplify this by appending -F to XFS_IO_PROG when it's needed -
> i.e. if we're using old xfsprogs on a non-xfs filesystem.
> This will eliminate errors when new tests leave out the -F, and
> if and when -F is finally removed, there will be one central
> location in xfstests to update.
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> V2: test for necessity of -F in all cases, and convert
> a bunch more direct callers of xfs_io to $XFS_IO_PROG

Yup, that fixes the one concern I had with the first patch.
Loks good.

Acked-by: Dave Chinner <dchinner@xxxxxxxxxx>


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>