xfs
[Top] [All Lists]

[PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT

To: xfs@xxxxxxxxxxx
Subject: [PATCH 2/2] Make test 306 use null and zero device nodes on SCRATCH_MNT
From: Jan Kara <jack@xxxxxxx>
Date: Wed, 8 May 2013 00:09:33 +0200
Cc: Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1367964573-29620-1-git-send-email-jack@xxxxxxx>
References: <1367964573-29620-1-git-send-email-jack@xxxxxxx>
In one place of test 306, we mistakenly used /dev/null and /dev/zero
instead of equivalent devices created on tested filesystem. So we were
not really testing the functionality we intended.

Signed-off-by: Jan Kara <jack@xxxxxxx>
---
 tests/generic/306 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/generic/306 b/tests/generic/306
index e8e0fc0..f45d142 100644
--- a/tests/generic/306
+++ b/tests/generic/306
@@ -73,9 +73,9 @@ _scratch_mount -o ro || _fail "Could not mount scratch 
readonly"
 echo "== try to create new file"
 touch $SCRATCH_MNT/this_should_fail 2>&1 | _filter_scratch
 echo "== pwrite to null device"
-$XFS_IO_PROG -F -c "pwrite 0 512" /dev/null | _filter_xfs_io
+$XFS_IO_PROG -F -c "pwrite 0 512" $DEVNULL | _filter_xfs_io
 echo "== pread from zero device"
-$XFS_IO_PROG -F -c "pread 0 512" /dev/zero | _filter_xfs_io
+$XFS_IO_PROG -F -c "pread 0 512" $DEVZERO | _filter_xfs_io
 
 echo "== truncating write to null device"
 echo foo > $DEVNULL 2>&1 | _filter_scratch
-- 
1.8.1.4

<Prev in Thread] Current Thread [Next in Thread>