xfs
[Top] [All Lists]

Re: Internal error xfs_sb_read_verify at line 726

To: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
Subject: Re: Internal error xfs_sb_read_verify at line 726
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 06 May 2013 12:04:16 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130506112717.GA502@x4>
References: <20130506112717.GA502@x4>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 5/6/13 6:27 AM, Markus Trippelsdorf wrote:
> Today I accidentally tried to mount my backup disk at /dev/sdc instead
> of /dev/sdc1 and this is what happened:
> 
> ...
> EXT4-fs (sdc): VFS: Can't find ext4 filesystem
> FAT-fs (sdc): bogus number of reserved sectors
> FAT-fs (sdc): Can't find a valid FAT filesystem
> FAT-fs (sdc): bogus number of reserved sectors
> FAT-fs (sdc): Can't find a valid FAT filesystem
> ISOFS: Unable to identify CD-ROM format.
> XFS (sdc): bad magic number
> ffff8800db620000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
> ................
> ffff8800db620010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
> ................
> ffff8800db620020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
> ................
> ffff8800db620030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
> ................
> XFS (sdc): Internal error xfs_sb_read_verify at line 726 of file 
> fs/xfs/xfs_mount.c.  Caller 0xffffffff8119e5cd

This seems to be a recent regression.

Comments above xfs_sb_quiet_read_verify() indicate that this behavior is
to be avoided:

 * We may be probed for a filesystem match, so we may not want to emit
 * messages when the superblock buffer is not actually an XFS superblock.

and it checks for proper magic prior to all the chattiness above int
that function.

The superblock read is suposed to choose whether to be noisy or not,
in xfs_readsb():

reread:
        bp = xfs_buf_read_uncached(mp->m_ddev_targp, XFS_SB_DADDR,
                                   BTOBB(sector_size), 0,
                                   loud ? &xfs_sb_buf_ops
                                        : &xfs_sb_quiet_buf_ops);

so it looks like this *should* be working properly.

I'll look into it and send a patch in a a bit.

(FWIW though, I don't get this probing from the kernel; I only
see it if I specify a -t xfs type on the mount command)

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>