xfs
[Top] [All Lists]

Re: xfs: add buffer types to directory and attribute buffers

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: xfs: add buffer types to directory and attribute buffers
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Mon, 06 May 2013 17:27:25 +0800
Cc: dchinner@xxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130506091116.GA2129@xxxxxxxxxxxxxx>
References: <20130506091116.GA2129@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
On 05/06/2013 05:11 PM, Dan Carpenter wrote:
> Hello Dave Chinner,
> 
> The patch d75afeb3d302: "xfs: add buffer types to directory and 
> attribute buffers" from Apr 3, 2013, leads to the following Smatch warning:
> "fs/xfs/xfs_log_recover.c:2042 xlog_recovery_validate_buf_type()
>        warn: always true condition '(magicda != 1480675917) =>  (0-u16max != 
> 1480675917)'"
> 
> fs/xfs/xfs_log_recover.c
>   2039          case XFS_BLFT_ATTR_RMT_BUF:
>   2040                  if (!xfs_sb_version_hascrc(&mp->m_sb))
>   2041                          break;
>   2042                  if (magicda != XFS_ATTR3_RMT_MAGIC) {
>                             ^^^^^^^
> This is an unsigned short so it can never be equal to 0x5841524d.  Was
> "magic32" intended here?
You are right, but this issue has been fixed by:

commit cab09a81fbefcb21db5213a84461d421946f6eb8
Author: Dave Chinner <dchinner@xxxxxxxxxx>
Date:   Tue Apr 30 21:39:36 2013 +1000

    xfs: fix da node magic number mismatches

It has been discussed on following thread before:
http://oss.sgi.com/archives/xfs/2013-04/msg00645.html

Thanks,
-Jeff
> 
>   2043                          xfs_warn(mp, "Bad attr remote magic!");
>   2044                          ASSERT(0);
>   2045                          break;
>   2046                  }
>   2047                  bp->b_ops = &xfs_attr3_rmt_buf_ops;
>   2048                  break;
> 
> regards,
> dan carpenter
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>