xfs
[Top] [All Lists]

re: xfs: add buffer types to directory and attribute buffers

To: dchinner@xxxxxxxxxx
Subject: re: xfs: add buffer types to directory and attribute buffers
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Mon, 6 May 2013 12:11:16 +0300
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
Hello Dave Chinner,

The patch d75afeb3d302: "xfs: add buffer types to directory and 
attribute buffers" from Apr 3, 2013, leads to the following Smatch warning:
"fs/xfs/xfs_log_recover.c:2042 xlog_recovery_validate_buf_type()
         warn: always true condition '(magicda != 1480675917) =>  (0-u16max != 
1480675917)'"

fs/xfs/xfs_log_recover.c
  2039          case XFS_BLFT_ATTR_RMT_BUF:
  2040                  if (!xfs_sb_version_hascrc(&mp->m_sb))
  2041                          break;
  2042                  if (magicda != XFS_ATTR3_RMT_MAGIC) {
                            ^^^^^^^
This is an unsigned short so it can never be equal to 0x5841524d.  Was
"magic32" intended here?

  2043                          xfs_warn(mp, "Bad attr remote magic!");
  2044                          ASSERT(0);
  2045                          break;
  2046                  }
  2047                  bp->b_ops = &xfs_attr3_rmt_buf_ops;
  2048                  break;

regards,
dan carpenter

<Prev in Thread] Current Thread [Next in Thread>