Re: [PATCH] xfstests 311: test fsync with dm flakey V3

[Rich Johnston <rjohnston@xxxxxxx>]

On 05/03/2013 12:30 PM, Josef Bacik wrote:
> On Fri, May 03, 2013 at 06:28:03AM -0600, Rich Johnston wrote:
> > Josef,
> >
> > The patch does not compile on older kernels (i.e. SLES11 SP2).
> >
> > fsync-tester.c: In function 'test_three':
> > fsync-tester.c:133: warning: implicit declaration of function 'syncfs'
> > /tmp/cciHR6Gb.o: In function `test_three':
> > /data/lwork/gulag1c/rjohnston/xfstests/src/fsync-tester.c:133: undefined
> > reference to `syncfs'
> > collect2: ld returned 1 exit status
> > gmake[3]: *** [fsync-tester] Error 1
> > gmake[2]: *** [src] Error 2
> > make[1]: *** [default] Error 2
> > make: *** [default] Error 2
> >
> >
> > src/fsync-tester.c
> > 133                                 syncfs(test_fd);
> > Typo ?????                          ^^^^^^
> > Did you mean fsync?
> Argh crap I should have noticed this in the manpage
>
> syncfs() first appeared in Linux 2.6.39
>
> You can just replace it with sync(), or do you want me to resend the patch with
> that change?  Thanks,
>
> Josef
No need to repost I will change it to sync() at commit time ;-)

--Rich