xfs
[Top] [All Lists]

Re: [PATCH] xfstests 311: test fsync with dm flakey V3

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 311: test fsync with dm flakey V3
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 3 May 2013 13:01:11 -0500
Cc: "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130503173001.GC12414@xxxxxxxxxxxxxxxxxxxxx>
References: <1367003639-17621-1-git-send-email-jbacik@xxxxxxxxxxxx> <5183AD53.7030403@xxxxxxx> <20130503173001.GC12414@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 05/03/2013 12:30 PM, Josef Bacik wrote:
On Fri, May 03, 2013 at 06:28:03AM -0600, Rich Johnston wrote:
Josef,

The patch does not compile on older kernels (i.e. SLES11 SP2).

fsync-tester.c: In function 'test_three':
fsync-tester.c:133: warning: implicit declaration of function 'syncfs'
/tmp/cciHR6Gb.o: In function `test_three':
/data/lwork/gulag1c/rjohnston/xfstests/src/fsync-tester.c:133: undefined
reference to `syncfs'
collect2: ld returned 1 exit status
gmake[3]: *** [fsync-tester] Error 1
gmake[2]: *** [src] Error 2
make[1]: *** [default] Error 2
make: *** [default] Error 2


src/fsync-tester.c
133                                 syncfs(test_fd);
Typo ?????                          ^^^^^^
Did you mean fsync?


Argh crap I should have noticed this in the manpage

syncfs() first appeared in Linux 2.6.39

You can just replace it with sync(), or do you want me to resend the patch with
that change?  Thanks,

Josef

No need to repost I will change it to sync() at commit time ;-)

--Rich

<Prev in Thread] Current Thread [Next in Thread>