| To: | Rich Johnston <rjohnston@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests 311: test fsync with dm flakey V3 |
| From: | Josef Bacik <jbacik@xxxxxxxxxxxx> |
| Date: | Fri, 3 May 2013 13:30:01 -0400 |
| Cc: | Josef Bacik <JBacik@xxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1367602204; bh=qMR7lyZGwIXe9sVSuMwvti8sdjHFWl2XztYGjPtzYsc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=MM5n9pHm25J9cgOhoRLLdBh7a5H+VrpDAg7scOJAbGF+3AjAyyDNj/Z88Ldm8Ljg8 CR7U/5IE6766KQdCHoRHgq3+8vEAfqmKeW14OKqLmaxO5qqOKj6ZYHt7ERZaeiUKU1 VeIOfWQYliryzJLcpLQOgYwfaWkK8gsoqehoh2m0= |
| In-reply-to: | <5183AD53.7030403@xxxxxxx> |
| References: | <1367003639-17621-1-git-send-email-jbacik@xxxxxxxxxxxx> <5183AD53.7030403@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2011-07-01) |
On Fri, May 03, 2013 at 06:28:03AM -0600, Rich Johnston wrote: > Josef, > > The patch does not compile on older kernels (i.e. SLES11 SP2). > > fsync-tester.c: In function 'test_three': > fsync-tester.c:133: warning: implicit declaration of function 'syncfs' > /tmp/cciHR6Gb.o: In function `test_three': > /data/lwork/gulag1c/rjohnston/xfstests/src/fsync-tester.c:133: undefined > reference to `syncfs' > collect2: ld returned 1 exit status > gmake[3]: *** [fsync-tester] Error 1 > gmake[2]: *** [src] Error 2 > make[1]: *** [default] Error 2 > make: *** [default] Error 2 > > > src/fsync-tester.c > 133 syncfs(test_fd); > Typo ????? ^^^^^^ > Did you mean fsync? > Argh crap I should have noticed this in the manpage syncfs() first appeared in Linux 2.6.39 You can just replace it with sync(), or do you want me to resend the patch with that change? Thanks, Josef |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: fix internal _xfs_check to handle logdev etc, Rich Johnston |
|---|---|
| Next by Date: | [PATCH V4] xfstests: make install support common/ and tests/ dirs, rjohnston |
| Previous by Thread: | Re: [PATCH] xfstests 311: test fsync with dm flakey V3, Rich Johnston |
| Next by Thread: | Re: [PATCH] xfstests 311: test fsync with dm flakey V3, Rich Johnston |
| Indexes: | [Date] [Thread] [Top] [All Lists] |