[Top] [All Lists]

Re: [PATCH V2] xfstests shared/298: various fixes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests shared/298: various fixes
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 3 May 2013 08:00:41 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <517FF548.1010309@xxxxxxxxxxx>
References: <517AE12C.2050902@xxxxxxxxxx> <517FF548.1010309@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
On 04/30/2013 11:46 AM, Eric Sandeen wrote:
fix shared/298:

* don't include common/config, not needed and breaks
   stuff when $SCRATCH_DEV_POOL is defined:
     Error: $SCRATCH_DEV should be unset when $SCRATCH_DEV_POOL is set
* make sure xfs_io has fiemap, we'll need it
* add -F to the xfs_io invocation, again, for use on
   old xfsprogs on non-xfs filesystems
* ignore ENOSPC errors from "garbage" loop; the only goal
   is to fill it, ENOSPC doesn't matter.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

V2: break out of copy loop when full

Dave, looks like Eric applied your suggestions, may I put your Reviewed-by on this one?

<Prev in Thread] Current Thread [Next in Thread>