xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix internal _xfs_check to handle logdev etc

To: sekharan@xxxxxxxxxx
Subject: Re: [PATCH] xfstests: fix internal _xfs_check to handle logdev etc
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 02 May 2013 13:31:26 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, "Michael L. Semon" <mlsemon35@xxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1367516658.4098.87.camel@xxxxxxxxxxxxxxxxxx>
References: <51827DDF.4050708@xxxxxxxxxx> <1367509132.4098.86.camel@xxxxxxxxxxxxxxxxxx> <51828F84.3040508@xxxxxxxxxxx> <1367516658.4098.87.camel@xxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 5/2/13 12:44 PM, Chandra Seetharaman wrote:
> On Thu, 2013-05-02 at 11:08 -0500, Eric Sandeen wrote:
>> On 5/2/13 10:38 AM, Chandra Seetharaman wrote:
>>> On Thu, 2013-05-02 at 09:53 -0500, Eric Sandeen wrote:
>>>> Pull all of the old xfs_check script into common/rc:_xfs_check()
>>>> so that it properly handles all options, including external log
>>>> devices.
>>>
>>> I see changes only related to USAGE. iiuc, log devices are handled
>>> properly by current code.
>>
>> also:
>>
>>>> +    set -- extra $@
>>>> +    shift $OPTIND
>>
>> have you *tested* log devices w/ your original code?  It failed for
>> Michael and for myself, so...  ;)
>>
>> -Eric
> 
> yikes. sorry :(

It's ok - I reviewed it, but I didn't test it.  ;)  It happens.

-Eric

<Prev in Thread] Current Thread [Next in Thread>