Re: [PATCH] xfstests: fix internal _xfs_check to handle logdev etc

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 5/2/13 12:44 PM, Chandra Seetharaman wrote:
> On Thu, 2013-05-02 at 11:08 -0500, Eric Sandeen wrote:
>> On 5/2/13 10:38 AM, Chandra Seetharaman wrote:
>>> On Thu, 2013-05-02 at 09:53 -0500, Eric Sandeen wrote:
>>>> Pull all of the old xfs_check script into common/rc:_xfs_check()
>>>> so that it properly handles all options, including external log
>>>> devices.
>>>
>>> I see changes only related to USAGE. iiuc, log devices are handled
>>> properly by current code.
>>
>> also:
>>
>>>> +    set -- extra $@
>>>> +    shift $OPTIND
>>
>> have you *tested* log devices w/ your original code?  It failed for
>> Michael and for myself, so...  ;)
>>
>> -Eric
> 
> yikes. sorry :(

It's ok - I reviewed it, but I didn't test it.  ;)  It happens.

-Eric