xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: Remove struct xfs_chash from xfs_mount
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 02 May 2013 10:09:06 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51824CA8.9000209@xxxxxxxxxx>
References: <51824CA8.9000209@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 05/02/13 06:23, Jeff Liu wrote:
v2->v1:
Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.


From: Jie Liu<jeff.liu@xxxxxxxxxx>

Remove struct xfs_chash from struct xfs_mount as there is no user of
it nowadays.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
Reviewed-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_mount.h |    2 --
  1 file changed, 2 deletions(-)

diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index bc90706..b68e56b 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -192,8 +192,6 @@ typedef struct xfs_mount {
         xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 
*/
         xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 
*/
         uint                    m_chsize;       /* size of next field */
-       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
-                                                * hash table */
         atomic_t                m_active_trans; /* number trans frozen */
  #ifdef HAVE_PERCPU_SB
         xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters 
*/

Your mailer may have damaged the patch. The <TAB> are now spaces.

FYI, I had problems with another patch of yours:
        http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
starting at the line:
        @@ -630,6 +688,12 @@ xfs_log_mount(

I think that this patch can be fixed rather resent. Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>