xfs
[Top] [All Lists]

Re: [PATCH 2/2 v2] xfs: Don't keep silent if sunit/swidth can not be cha

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH 2/2 v2] xfs: Don't keep silent if sunit/swidth can not be changed via mount
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 May 2013 17:20:24 +1000
Cc: Mark Tinguely <tinguely@xxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51820D8E.7040308@xxxxxxxxxx>
References: <518125CF.3050806@xxxxxxxxxx> <20130502011302.GS10481@dastard> <51820D8E.7040308@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, May 02, 2013 at 02:54:06PM +0800, Jeff Liu wrote:
> On 05/02/2013 09:13 AM, Dave Chinner wrote:
> > On Wed, May 01, 2013 at 10:25:19PM +0800, Jeff Liu wrote:
> >> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> >> index 29e8de8..2836ef6 100644
> >> --- a/fs/xfs/xfs_mount.c
> >> +++ b/fs/xfs/xfs_mount.c
> >> @@ -909,6 +909,10 @@ xfs_update_alignment(xfs_mount_t *mp)
> >>                            sbp->sb_width = mp->m_swidth;
> >>                            mp->m_update_flags |= XFS_SB_WIDTH;
> >>                    }
> >> +          } else {
> >> +                  xfs_warn(mp, "cannot change alignment: "
> >> +                           "superblock does not support data alignment");
> > 
> > Same comment again about single line format strings. Otherwise it's
> > ok.
> Ah, sorry! I misunderstood the comments of Mark before. I was bluffed
> into believing that I should cut the length of log string as short as
> possible. :(

Thing of being able cut-n-paste the error message out of the log and
then being able to grep the source tree for it. i.e.

$ git grep "cannot change alignment: superblock does not support data alignment"

Will fail to find anything in the former case, but in the single
line case it will identify the file the error lies in immediately.
So the question I always ask myself is "is that format string easy
to find with grep?" :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>