[Top] [All Lists]

Re: Cleancache support in XFS

To: James Dingwall <james.dingwall@xxxxxxxxxxx>
Subject: Re: Cleancache support in XFS
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 1 May 2013 11:20:44 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51810CED.4080003@xxxxxxxxxxx>
References: <51810CED.4080003@xxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hi James, 

On Wed, May 01, 2013 at 01:39:09PM +0100, James Dingwall wrote:
> In reference to: http://oss.sgi.com/archives/xfs/2012-05/msg00046.html
> $ grep -r cleancache fs/xfs
> on the 3.9 kernel source suggests that no patch was submitted to
> enable cleancache for the XFS filesystem.  Since it was suggested
> that this could be a one liner I've had a go and my first effort is
> inline below.  While this seems to compile OK I have no experience
> in filesystems so I would appreciate it if anyone can point out that
> it is obviously wrong and likely to eat my data before I try booting
> the kernel.
> If it seems a reasonable attempt what would be the best way to check
> that it isn't doing nasty things?

Hrm.. Looks like there is a doc in Documentation/vm/cleancache.txt which
includes a list of attributes the filesystem needs to have to work properly
with cleancache.  I'd suggest going over that list and the code by inspection
first, followed by some xfstests runs, and then wait for it to make a release
before trusting any data to it.  For a test machine that I'm willing to crater,
no worries.  But I wouldn't run this on my main workstation without doing the
above first.  We can probably explore this for 3.11.  Thanks for the patch.


<Prev in Thread] Current Thread [Next in Thread>