xfs
[Top] [All Lists]

Cleancache support in XFS

To: <xfs@xxxxxxxxxxx>
Subject: Cleancache support in XFS
From: James Dingwall <james.dingwall@xxxxxxxxxxx>
Date: Wed, 1 May 2013 13:39:09 +0100
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1
In reference to: http://oss.sgi.com/archives/xfs/2012-05/msg00046.html

$ grep -r cleancache fs/xfs
on the 3.9 kernel source suggests that no patch was submitted to enable cleancache for the XFS filesystem. Since it was suggested that this could be a one liner I've had a go and my first effort is inline below. While this seems to compile OK I have no experience in filesystems so I would appreciate it if anyone can point out that it is obviously wrong and likely to eat my data before I try booting the kernel.

If it seems a reasonable attempt what would be the best way to check that it isn't doing nasty things?

Thanks,
James

--- xfs_super.c 2013-04-29 10:28:22.000000000 +0100
+++ xfs_super.cleancache.c      2013-05-01 13:22:44.367763564 +0100
@@ -61,6 +61,7 @@
 #include <linux/kthread.h>
 #include <linux/freezer.h>
 #include <linux/parser.h>
+#include <linux/cleancache.h>

 static const struct super_operations xfs_super_operations;
 static kmem_zone_t *xfs_ioend_zone;
@@ -1489,6 +1490,8 @@
                goto out_unmount;
        }

+       cleancache_init_fs(sb);
+
        return 0;

  out_filestream_unmount:

<Prev in Thread] Current Thread [Next in Thread>