xfs
[Top] [All Lists]

Re: [TARBALL] xfsprogs: fixes and updates to current kernel code

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [TARBALL] xfsprogs: fixes and updates to current kernel code
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 1 May 2013 06:11:37 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <517FE1A4.9010708@xxxxxxx>
References: <20130430121300.GB10481@dastard> <517FE1A4.9010708@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 30, 2013 at 10:22:12AM -0500, Mark Tinguely wrote:
> On 04/30/13 07:13, Dave Chinner wrote:
> >
> >Hi folks,
> >
> >The attached tarball contains the following patches and a series
> >file:
> >
> >xfs_repair: validate on-disk extent count better
> 
> Looks okay.
> 
> >xfs_logprint: print all AGI unlinked buckets
> 
> I understand that the AGI print in xlog_recover_print_buffer() came
> from xlog_print_trans_buffer(). The entries are added to the
> agi_unlinked[] indexed by (agino % XFS_AGI_UNLINKED_BUCKETS). Why
> limit the number of agi_unlinked entries base on the xfs_log_iovec
> region length? Commit 2bd0ea1 that put this code into
> log_print_trans_buffer() did not enlighten me.

Because we may only log partial regions of the AGI. The size of the
region determines how many unlinked buckets are in the region that
can be printed....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>