xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests generic/306 fixes and updates

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests generic/306 fixes and updates
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 1 May 2013 06:09:40 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <517FD25B.7060206@xxxxxxxxxxx>
References: <517AD562.3060208@xxxxxxxxxx> <517E9B52.7030008@xxxxxxxxxxx> <20130430074052.GJ23072@dastard> <517FD25B.7060206@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 30, 2013 at 09:16:59AM -0500, Eric Sandeen wrote:
> On 4/30/13 2:40 AM, Dave Chinner wrote:
> > On Mon, Apr 29, 2013 at 11:09:54AM -0500, Eric Sandeen wrote:
> >> older xfs_io refused to write to /dev/null because it's
> >> not a file on an xfs filesystem.  So add -F.
> > 
> > You could just do:
> > 
> > export XFS_IO_PROG="$XFS_IO_PROG -F"
> > 
> > and not have to change so much of the test. And with a comment it
> > would make it obvious to a future ready why the -F flag is used ;)
> > 
> > Cheers,
> > 
> > Dave.
> > 
> 
> Well, it's not just this test; it's any non-xfs-specific test
> which uses xfs_io for anything at all.  We have -F's sprinkled
> through many tests for that reason, even though -F is deprecated upstream.
> 
> There are 15 non-xfs-specific tests which use XFS_IO_PROG:

OK, sounds like we should detect if it is needed when setting up
XFS_IO_PROG in common/config rather than changing every test....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>