On Tue, Apr 30, 2013 at 09:16:59AM -0500, Eric Sandeen wrote:
> On 4/30/13 2:40 AM, Dave Chinner wrote:
> > On Mon, Apr 29, 2013 at 11:09:54AM -0500, Eric Sandeen wrote:
> >> older xfs_io refused to write to /dev/null because it's
> >> not a file on an xfs filesystem. So add -F.
> >
> > You could just do:
> >
> > export XFS_IO_PROG="$XFS_IO_PROG -F"
> >
> > and not have to change so much of the test. And with a comment it
> > would make it obvious to a future ready why the -F flag is used ;)
> >
> > Cheers,
> >
> > Dave.
> >
>
> Well, it's not just this test; it's any non-xfs-specific test
> which uses xfs_io for anything at all. We have -F's sprinkled
> through many tests for that reason, even though -F is deprecated upstream.
>
> There are 15 non-xfs-specific tests which use XFS_IO_PROG:
OK, sounds like we should detect if it is needed when setting up
XFS_IO_PROG in common/config rather than changing every test....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
|