xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests generic/306 fixes and updates

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests generic/306 fixes and updates
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 30 Apr 2013 17:40:52 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <517E9B52.7030008@xxxxxxxxxxx>
References: <517AD562.3060208@xxxxxxxxxx> <517E9B52.7030008@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 29, 2013 at 11:09:54AM -0500, Eric Sandeen wrote:
> older xfs_io refused to write to /dev/null because it's
> not a file on an xfs filesystem.  So add -F.

You could just do:

export XFS_IO_PROG="$XFS_IO_PROG -F"

and not have to change so much of the test. And with a comment it
would make it obvious to a future ready why the -F flag is used ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>