xfs
[Top] [All Lists]

Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs

To: Josef Bacik <jbacik@xxxxxxxxxxxx>
Subject: Re: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 26 Apr 2013 14:18:26 -0500
Cc: linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1367003813-17686-1-git-send-email-jbacik@xxxxxxxxxxxx>
References: <1367003813-17686-1-git-send-email-jbacik@xxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
On 4/26/13 2:16 PM, Josef Bacik wrote:
> mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk 
> instead
> of just a partition, so any xfstest that uses a scratch device and you 
> specify a
> full disk will appear to hang because it's waiting for you to say yes.  This
> fixes the problem by just forcing it to do its thing.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

The whole-disk test is pretty derpy anyway. Too bad -F overrides
much more than just that, but this is probably a decent
thing to do.

Thanks,
-Eric

> ---
>  common/rc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index ff18cc2..9d1c3fc 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -485,7 +485,7 @@ _scratch_mkfs_ext4()
>  {
>       local tmp_dir=/tmp/
>  
> -     /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV \
> +     /sbin/mkfs -t $FSTYP -- -F $MKFS_OPTIONS $* $SCRATCH_DEV \
>                       2>$tmp_dir.mkfserr 1>$tmp_dir.mkfsstd
>       local mkfs_status=$?
>  
> 

<Prev in Thread] Current Thread [Next in Thread>