[Top] [All Lists]

[PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs

To: <linux-ext4@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Subject: [PATCH] [PATCH] xfstests: use -F when making scratch ext4 fs
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Fri, 26 Apr 2013 15:16:53 -0400
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1367003815; bh=x+hl+rUOfQh7xO2z0YPEPnSsRvJlFOqrgne5sXRzZqo=; h=From:To:Subject:Date; b=rx0NqwsHCL+ICDzgKzkLKIiApcOWLi2f4n2+QkJFu3NCsBWYTh2nxTYMlS9Mjo9mH nwNbX1ghvBDvRiTUtY09Q/X1712d5i9o5UTax0lqHSXlWIEoocL1hCavEfInI+Nx+p MuAnR+pGry5gaSUOFRtBPrYD0CmLTc/0nHXXxAbE=
mkfs.ext4 will ask you if you are sure if you try to mkfs an entire disk instead
of just a partition, so any xfstest that uses a scratch device and you specify a
full disk will appear to hang because it's waiting for you to say yes.  This
fixes the problem by just forcing it to do its thing.  Thanks,

Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
 common/rc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/rc b/common/rc
index ff18cc2..9d1c3fc 100644
--- a/common/rc
+++ b/common/rc
@@ -485,7 +485,7 @@ _scratch_mkfs_ext4()
        local tmp_dir=/tmp/
-       /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV \
+       /sbin/mkfs -t $FSTYP -- -F $MKFS_OPTIONS $* $SCRATCH_DEV \
                        2>$tmp_dir.mkfserr 1>$tmp_dir.mkfsstd
        local mkfs_status=$?

<Prev in Thread] Current Thread [Next in Thread>