[Top] [All Lists]

Re: [PATCH TARBALL, DEV ONLY] xfsprogs: metadata CRC support V2

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH TARBALL, DEV ONLY] xfsprogs: metadata CRC support V2
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 26 Apr 2013 07:40:40 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51799C24.8010901@xxxxxxx>
References: <20130412145555.GF30622@dastard> <51799C24.8010901@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 25, 2013 at 04:12:04PM -0500, Mark Tinguely wrote:
> On 04/12/13 09:55, Dave Chinner wrote:
> >Hi folks,
> >
> >I've attached a tarball containing the patch series that adds
> >metadata CRC support to xfsprogs. It is still very much a work in
> >progress, but is sufficient to start running xfstests on CRC enable
> >filesystems.
> >
> >THere is much missing functionality, especially with respect to
> >directly/attribute modifications. Only mkfs and xfs_repair have been
> >updated to explicitly support CRC on directory/sttribute blocks,
> >though all the other tools will stil run the result might be a
> >little unpredictable.
> >
> >The patch series is as follows:
> >
> BTW forgot about this gem, the UBER/xfsprogs-kernel-3.8-update patch
> has been kicking up duplicate defines in sles11sp2 (gcc 4.3.4), but
> fine in newer distros (gcc 4.6.2). Looks like a compile difference
> issue:
> xfs_dir2_data_aoff_t  xfs_dir2_format.h and xfs_dir2.h
> xfs_dir2_db_t         xfs_dir2_format.h and xfs_dir2.h
> The one below seems new to me:
> prid_t                project.h and xfs_types.h
> I have been removing the entry in xfs_dir2_format.h in the past to test.
> I don't remember the prid_t duplicate.

Hmmmm. I'm not getting those warnings here (gcc-4.7.2). I'll have a
look into it....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>