xfs
[Top] [All Lists]

Re: [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compa

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: xfs: fallback to vmalloc for large buffers in xfs_compat_attrlist_by_handle
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 25 Apr 2013 11:43:37 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <51795612.3080806@xxxxxxxxxxx>
References: <515CB2C1.1050109@xxxxxxxxx> <20130404035237.GA12011@dastard> <515D0A09.5030808@xxxxxxxxxxx> <51795612.3080806@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/25/13 11:13, Eric Sandeen wrote:
Shamelessly copied from dchinner's:
ad650f5b xfs: fallback to vmalloc for large buffers in xfs_attrmulti_attr_get

xfsdump uses a large buffer for extended attributes, which has a
kmalloc'd shadow buffer in the kernel. This can fail after the
system has been running for some time as it is a high order
allocation. Add a fallback to vmalloc so that it doesn't require
contiguous memory and so won't randomly fail while xfsdump is
running.

This was done for xfs_attrlist_by_handle but
xfs_compat_attrlist_by_handle (the 32-bit version) needs the same
attention.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

Looks shamelessly good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>