xfs
[Top] [All Lists]

Re: [PATCH 3/3 V2] xfsprogs: Fix up usage() errors and omissions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 3/3 V2] xfsprogs: Fix up usage() errors and omissions
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Thu, 25 Apr 2013 11:13:29 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <517948D2.7070706@xxxxxxxxxxx>
References: <5175BB8F.5090604@xxxxxxxxxxx> <5175BCBE.8040306@xxxxxxxxxxx> <517948D2.7070706@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 04/25/2013 10:16 AM, Eric Sandeen wrote:
Add missing options and remove invalid options in usage() output
strings.

* Add -V to several usage() strings
* Remove deprecated/invalid -n and -s otions from xfs_fsr's usage
* Remove invalid -I option from xfs_growfs's usage
* Add -n (O_NONBLOCK) option to xfs_io's usage
* Add -e (exit on error) option to xfs_logprint's usage
* Remove invalid -b option from xfs_mdrestore's usage
* Add -N (no-op), -K (no discard), and -f (force) to mkfs.xfs's usage
* Add -x (expert) option to xfs_quota's usage

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

V2: address Rich's nitpicky review ;)  (i.e. fix good stuff)

Thanks again for V2.  Looks good.

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>