xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: capture the failure result of 310

To: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: capture the failure result of 310
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 23 Apr 2013 08:33:02 -0500
Cc: <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <5175FC5C.5020607@xxxxxxxxxx>
References: <5175FC5C.5020607@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Thanks for making the suggested changes.

FYI it helps the review process if you include a version log below the header something like.

  Capture the failure by the way of counting dmesg errors and describe
  how the test triggers problems.

  Signed-off-by: Zhao Hongjiang <zhaohongjiang@xxxxxxxxxx>
  [eguan@xxxxxxxxxx fix common file path and other cleanups]

  ---
  V1:
        Initial version

  V2:
        Added suggestions from xxx@xxxxxxxxxxxxx to fix something
        Reworked logic for function blah

Minor description change, other than that, it looks good.

--Rich

Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>