xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfstests: Use libtool to install applications

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH 2/5] xfstests: Use libtool to install applications
From: Boris Ranto <ranto.boris@xxxxxxxxx>
Date: Thu, 18 Apr 2013 14:25:04 +0200
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=ONsSTYAX7b8aCO3hGc95UXQJDF7pP5FAWlfSyxyBDcw=; b=XQt7fvCjJhVfnJLw/RxHWsB0N+36rcBrlNPEoguRDVjmyrnnlmA5eaShgPzVKtCJSW a59KsDbHPvflQiFV54PJRT7B3z+f2fyVtA2vrcOcwIuEDhsEjVNDjTC8yv57hG2wAr9z /cw5Q5pFDYx4+P2BmM1c6BbPK22TQvi891OXtrZfVSGRqfE2NlEgE7hmCX7EBgo/V+Oq pJVvl+Q5iEQxa1iEDELgRe3RAFou+ZbhYAcDW7tLRI4MXwLiHKEi/iqYF31Zosh+UmU5 mttOcewI8m9G3oI1pClzAuxoWiYFk5vw2i8T+KI9yXO+FiBtVEEvUt5PLiMdVJnG7xXx 1OFg==
In-reply-to: <516EB6E3.9040903@xxxxxxx>
References: <20120828172605.607853317@xxxxxxx> <20120828172928.999971219@xxxxxxx> <CAFZPdfgFjRS2rFUekfSr4dT+-sfuji-0uUo1i7VE6=9GZOnzfg@xxxxxxxxxxxxxx> <516EB6E3.9040903@xxxxxxx>
Rich,

just as Eric guessed, I package the xfstests test suite (and that is also why I need the DIST_ROOT variable functioning properly). Although I can currently work around the problem  by doing something like

./configure
make
mkdir -p /var/lib/xfstets/{ltp,src}
make DIST_ROOT=$RPM_BUILD_ROOT install

it certainly is not the best solution to the problem. If the test suite is completely independent from its location then also maybe this could work (I did not try it, yet and I'm still not sure it is the best solution)

./configure --prefix=$RPM_BUILD_ROOT
make
make install

but if that is the case then it'd probably make sense to drop the whole DIST_ROOT support from install-sh script to avoid confusion and update the spec file in bulld/rpm/.

Regards,
Boris

(Rich, sorry for the duplicate message, I forgot to cc mailing list the first time.)


On Wed, Apr 17, 2013 at 4:51 PM, Rich Johnston <rjohnston@xxxxxxx> wrote:
Boris,

Most people do not install xfstests, as it is not required to run the tests.  Is there a reason you need to install xfstests? It is designed to be run from the directory you did the git clone from.  Path is not critical so you could move it anywhere you wish.

i.e.
git clone git://oss.sgi.com/xfs/cmds/xfstests
mv xfstests /new/path/new_xfsdirname
cd /new/path/new_xfsdirname
./check -g auto


--Rich

<Prev in Thread] Current Thread [Next in Thread>