xfs
[Top] [All Lists]

Bug#695640: xfs_quota: cannot find mount point for path: Success

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Bug#695640: xfs_quota: cannot find mount point for path: Success
From: Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 18 Apr 2013 09:38:11 +1000
Cc: 695640@xxxxxxxxxxxxxxx, Ben Myers <bpm@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microcomaustralia.com.au; s=google; h=mime-version:x-received:x-originating-ip:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=N9AAX450zvDKFMG9w8LHrXstLa1KwW+rpptLVYMj3MI=; b=F9KB5pCgKsm9ZhBD/TOy0JMy6WwcKd4ZRTPB9jWOaoLvU3ohC1+HPsISqDiYuFwYdO 2QQry+4D0WoK6MGqVerIXkUbX2eIrJM9pxghundpX+aYuOieYiAVyLaXH2XLA3VvbcUB oBWYJvxD6PxC8yyOPsfqkrfYR0lljpKmTazvY=
In-reply-to: <20130320110935.GE17758@dastard>
References: <CAA0ZO6APzwQCX=yf=qq8NkmjwDHVsgRBNCgN3KNW3RLgAWB=8A@xxxxxxxxxxxxxx> <20121211223700.GA27055@xxxxxxx> <CAA0ZO6BOUXTMpdrR-r=__-ZaAM6X39h2SisYXLfTTraTcttr+g@xxxxxxxxxxxxxx> <20121211231533.GG16353@dastard> <CAA0ZO6BvLQGt_9G-FSi+ZMCzJh_kmb1z2bdoPPwaVMVVK1UXJw@xxxxxxxxxxxxxx> <CAA0ZO6BGqvBdXRr9U4BagQYGa=_kC2VUgtOj+qPB5HEX2U8O7w@xxxxxxxxxxxxxx> <20130318224814.GP6369@dastard> <CAA0ZO6BVwPP9McKA=vn1+21gHpRCQP9P963nsSjY_zXHWeszrg@xxxxxxxxxxxxxx> <20130319063104.GA6369@dastard> <CAA0ZO6AxFzinTv_COhK6GqnRpSiYW95otznKvYKiWZB5+=CyBg@xxxxxxxxxxxxxx> <20130320110935.GE17758@dastard>
Reply-to: Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>, 695640@xxxxxxxxxxxxxxx
Resent-cc: XFS Development Team <xfs@xxxxxxxxxxx>
Resent-date: Wed, 17 Apr 2013 23:42:02 +0000
Resent-from: Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>
Resent-message-id: <handler.695640.B695640.136624189830432@xxxxxxxxxxxxxxx>
Resent-sender: Debian BTS <debbugs@xxxxxxxxxxxxxxxxxxxx>
Resent-to: debian-bugs-dist@xxxxxxxxxxxxxxxx
Oops. Just realized I still hadn't responded. Sorry.


On 20 March 2013 22:09, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > # xfs_quota Â-x -c "quota -N -u brian"
>
> This prints the quota information 20 times. Huh?

How many mount points do you have? 20?

No. More actually. Today I get

hq ~ # cat /proc/mounts Â| wc --lines
34
hq ~ # xfs_quota Â-x -c "quota -N -u brian" | wc --lines
44
hq ~ # xfs_quota Â-x -c "quota -N -u brian" /home /share | wc --lines
4
Â
The command has once for each of the mount points, and the command
itself iterates mount points because you haven't given it a mount
point to look at. So, double iteration. ÂThis same problem was fixed
for the report command by setting it to be a global command i.e. the
fix I mentioned previously that you tested should prevent this
second case, and maybe even the first.

As far as I can tell this happens with the patched xfs_quota.

hq /home/brian/xfsprogs # git diff
diff --git a/quota/quot.c b/quota/quot.c
index a7782b4..6cb665d 100644
--- a/quota/quot.c
+++ b/quota/quot.c
@@ -418,6 +418,7 @@ quot_init(void)
    quot_cmd.args = _("[-bir] [-gpu] [-acv] [-f file]");
    quot_cmd. filesystem ownership");
    quot_cmd.help = quot_help;
+ Â Â Â quot_cmd.flags = CMD_FLAG_GLOBAL;
Â
    if (expert)
        add_command(&quot_cmd);

As this version is based on git, I just did a git pull:

hq /home/brian/xfsprogs # git pull
Updating b326e06..64ae7fc
Fast-forward
Âmkfs/xfs_mkfs.c | Â 18 ++++++++++++++++++
Â1 files changed, 18 insertions(+), 0 deletions(-)

Doesn't look related to this, don't think I need to retest.
--
Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>
<Prev in Thread] Current Thread [Next in Thread>
  • Bug#695640: xfs_quota: cannot find mount point for path: Success, Brian May <=