[Top] [All Lists]

Re: [PATCH] xfs: don't return 0 if generic_segment_checks() find nothing

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfs: don't return 0 if generic_segment_checks() find nothing to write
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Wed, 17 Apr 2013 02:35:54 +0800
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130416182624.GK22182@xxxxxxx>
References: <51682CCC.308@xxxxxxxxxx> <20130416182624.GK22182@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2
Hi Ben,

On 04/17/2013 02:26 AM, Ben Myers wrote:
> Hey Jeff,
> On Fri, Apr 12, 2013 at 11:48:28PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@xxxxxxxxxx>
>> At xfs_file_aio_write(), we just return 0 which means a successfully 
>> operation if the ocount
>> is evaluated to 0 at generic_segment_checks().  Generally, it'll occurred if 
>> the specified
>> write count is 0 from the user space.  However, for example, if the given 
>> offset is over the
>> maximum file size limitation although nothing would be written into the 
>> file, in this case,
>> the underlying file system should detect this issue and return a proper 
>> errno instead.
>> Hence, the beginning pre-checking up against ocount would conceal some real 
>> cause and confuse
>> the user space program maybe.
>> To fix it, we can delay the write count verification until 
>> xfs_file_aio_write_checks() is done.
> Could you wrap these around 72 columns or so in the future?  Don't worry
> about reposting this one unless something technical comes up.
Sure, I'll take care of the patch format in the future.


<Prev in Thread] Current Thread [Next in Thread>