xfs
[Top] [All Lists]

Re: [PATCH v3] xfstests: make install support common/ and tests/ dirs

To: Rich Johnston <rjohnston@xxxxxxx>
Subject: Re: [PATCH v3] xfstests: make install support common/ and tests/ dirs
From: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Date: Tue, 16 Apr 2013 07:28:52 +0800
Cc: Dave Chinner <dchinner@xxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=wcCNR2mAuBBU3X8eZcsdQyhlo5mWcFyn+G6+WfT5UEU=; b=BNi0+1HHeiwwAjxLT1gSB+UvavC5O0rFuhFSECAKVaJx8a4L4SsuB3kOaDoAtiBSEh 9U11WzOexDLRabq5k1+326mZrMD5zjG75vbXTMAhaa0N5ZS7XbkE1lTsb4QCT5OQ1npX pYBWHyo5ncJbDh6DaRqXVgzGEnlhsv7RZcRJ4vZOK91M33Sb5N/l7Y0EBEb9CPgY4ZgL fOun+8T/GbGmQVB9YsPzmi2sU7aKxtwzdd6u/lb6MdCLw/J7429msEQ4VIJ6+mpWNHZK zdwet8VNFUB3JFJqV2s47q9xjO5RcahYsjm88uMZvVQB+VlB+1Scwe9DBaCblNMo13TY iVMg==
In-reply-to: <516BFA10.6020102@xxxxxxx>
References: <516937F9.1020101@xxxxxxxxx> <516BFA10.6020102@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 2013å04æ15æ 21:01, Rich Johnston wrote:
On 04/13/2013 05:48 AM, Wang Sheng-Hui wrote:

diff --git a/Makefile b/Makefile
index 6edd55c..611b36d 100644
--- a/Makefile
+++ b/Makefile
@@ -52,12 +52,15 @@ LDIRT += $(SRCTAR)
  endif

  LIB_SUBDIRS = include lib
-TOOL_SUBDIRS = ltp src m4
+TOOL_SUBDIRS = ltp src m4 common
  ifeq ($(HAVE_DMAPI), true)
  TOOL_SUBDIRS += dmapi
  endif

-SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS)
+TESTS_DIR = tests
+export TESTS_DIR
+
+SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS) $(TESTS_DIR)

  default: include/builddefs $(DMAPI_MAKEFILE) $(TESTS)
  ifeq ($(HAVE_BUILDDEFS), no)
@@ -91,12 +94,7 @@ depend: include/builddefs $(addsuffix
-depend,$(SUBDIRS))
  install: default $(addsuffix -install,$(SUBDIRS))
      $(INSTALL) -m 755 -d $(PKG_LIB_DIR)
      $(INSTALL) -m 755 check $(PKG_LIB_DIR)
-    $(INSTALL) -m 755 [0-9]?? $(PKG_LIB_DIR)
-    $(INSTALL) -m 755 run.* $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 group $(PKG_LIB_DIR)
      $(INSTALL) -m 644 randomize.awk $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 [0-9]??.* $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 common* $(PKG_LIB_DIR)

  # Nothing.
  install-dev install-lib:


Not sure why Makefile above would not apply. I did the following:

git reset --hard 2bfce6d3 # Revert to commit before v2 of this patch.

Attemted to apply patch

Applying patch v3-xfstests-make-install-support-common-and-tests-dirs.patch
patching file Makefile
Hunk #1 FAILED at 52.
Hunk #2 FAILED at 94.
2 out of 2 hunks FAILED -- rejects in file Makefile

So I replaced your Makefile patch with

  > diff --git a/Makefile b/Makefile
index 6edd55c..b01491e 100644
--- a/Makefile
+++ b/Makefile
@@ -52,12 +52,14 @@ LDIRT += $(SRCTAR)
 endif

 LIB_SUBDIRS = include lib
-TOOL_SUBDIRS = ltp src m4
+TOOL_SUBDIRS = ltp src m4 common
 ifeq ($(HAVE_DMAPI), true)
 TOOL_SUBDIRS += dmapi
 endif

-SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS)
+TESTS_DIR = tests
+export TESTS_DIR
+SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS) $(TESTS_DIR)

 default: include/builddefs $(DMAPI_MAKEFILE) $(TESTS)
 ifeq ($(HAVE_BUILDDEFS), no)
@@ -91,12 +93,7 @@ depend: include/builddefs $(addsuffix -depend,$(SUBDIRS))
 install: default $(addsuffix -install,$(SUBDIRS))
     $(INSTALL) -m 755 -d $(PKG_LIB_DIR)
     $(INSTALL) -m 755 check $(PKG_LIB_DIR)
-    $(INSTALL) -m 755 [0-9]?? $(PKG_LIB_DIR)
-    $(INSTALL) -m 755 run.* $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 group $(PKG_LIB_DIR)
     $(INSTALL) -m 644 randomize.awk $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 [0-9]??.* $(PKG_LIB_DIR)
-    $(INSTALL) -m 644 common* $(PKG_LIB_DIR)

 # Nothing.
 install-dev install-lib:

Will revert v2 (git revert 2519a97d) and commit with this minor change is Dave 
agrees to your latest version.

Thanks, Rich!

Regards,
Sheng-Hui


Thanks
--Rich



<Prev in Thread] Current Thread [Next in Thread>