|To:||Dave Chinner <david@xxxxxxxxxxxxx>|
|Subject:||Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs|
|From:||Rich Johnston <rjohnston@xxxxxxx>|
|Date:||Mon, 15 Apr 2013 07:45:00 -0500|
|Cc:||Wang Sheng-Hui <shhuiw@xxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfstests <xfs@xxxxxxxxxxx>|
|References:||<51678D0D.1070002@xxxxxxxxx> <20130412074034.GC30622@dastard> <5168396C.6020801@xxxxxxxxx> <51685552.6030808@xxxxxxx> <20130413003829.GH30622@dastard>|
|User-agent:||Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1|
On 04/12/2013 07:38 PM, Dave Chinner wrote:
On Fri, Apr 12, 2013 at 01:41:22PM -0500, Rich Johnston wrote:On 04/12/2013 11:42 AM, Wang Sheng-Hui wrote:Hi Dave, I introduces Makefile under tests/, which would return to TESTS_SUBDIRS with the $(dir function. By running find in $(shell, TEST_SUBDIRS will only get the dir names, and no Makefile. Regards, Sheng-HuiThanks addressing comments and for v2 of this patch. I still had issues with Makefile which I corrected at commit time. Thanks again for the patch, it has been committed,Rich, it's great that you are picking this stuff up quickly, but as I asked recently, please don't commit patches while there is still an active review conversation going on.... Cheers, Dave.
Dave,I was a little quick on the draw, I will wait till all parties have concluded discussions.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Rich Johnston|
|Next by Date:||Re: need help how to debug xfs crash issue xfs_iunlink_remove: xfs_inotobp() returned error 22, 符永涛|
|Previous by Thread:||Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Rich Johnston|
|Next by Thread:||Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs, Dave Chinner|
|Indexes:||[Date] [Thread] [Top] [All Lists]|