xfs
[Top] [All Lists]

xfstests: kludge patch for per-dir test number sorting by ./check

To: xfstests <xfs@xxxxxxxxxxx>
Subject: xfstests: kludge patch for per-dir test number sorting by ./check
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Sat, 13 Apr 2013 16:50:06 -0400
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=bBJzJC0wR8+9DWlzCtfx1drvvXCHb3Yg/4IkqneKjwA=; b=KI6TxV2zwA+ofSdUVVWGgduMat/jBOIMXor+qqzDpQh60uKQmdKXUevRKAdxvUc4AL SIA9fEvZOBHlTa7xu3FDI7zACNrekkbXHMaCMdrVlne2kfvxW9Hx35cbZAK4RLed4KSw fpIksHPLOOzEHiWMw1/bZ9B6UoV1EFPIGP/Ka4KPQ3LebOGkGXaZJtQcXXSR5AZN1IVo eyswLPi689m/ZPile/EjpFBMtWtvdXHbIbUFjCDwu39H2Fho0rXK1qqBcYdCW2ltWxyk Ty8JxsIAJDQPe1Ge8S2cHKsn9XpvPz0sg3JsIrGBrMbhzrYoARPLGvyygJPLg5O12T+B 69AQ==
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
I'm trying to get the new xfstests to run the XFS tests first, then run the generic group, then run the shared group. One attempt was to work with this variable in the ./check script:

SRC_GROUPS="generic shared"

There is a final file sort in ./check that means, no matter which order groups are specified in SRC_GROUPS, the groups will be executed in alphabetical order. This sysadmin kludge patch fixes that behavior and seems to work. By moving the sorting into the trim_test_list() function, test numbers are still sorted, but the groups seem to run in the order specified in the SRC_GROUPS variable.

Let me know if this helps or if I'm simply not using the new xfstests correctly.

Michael

--- xfstests/check.orig 2013-03-30 00:54:37.000000000 -0400
+++ xfstests/check      2013-04-13 13:41:42.002814733 -0400
@@ -138,7 +138,7 @@
            echo "^$t\$" >>$tmp.grep
            numsed=`expr $numsed + 1`
        done
-       grep -v -f $tmp.grep <$tmp.list >$tmp.tmp
+       grep -v -f $tmp.grep <$tmp.list | sort -n >$tmp.tmp
        mv $tmp.tmp $tmp.list
 }

@@ -268,7 +268,7 @@
 fi

 # sort the list of tests into numeric order
-list=`sort -n $tmp.list`
+list=`cat $tmp.list`
 rm -f $tmp.list $tmp.tmp $tmp.grep

 if $randomize

<Prev in Thread] Current Thread [Next in Thread>