[Top] [All Lists]

Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: make install support common/ and tests/ dirs
From: Wang Sheng-Hui <shhuiw@xxxxxxxxx>
Date: Sat, 13 Apr 2013 00:42:20 +0800
Cc: Dave Chinner <dchinner@xxxxxxxxxx>, Rich Johnston <rjohnston@xxxxxxx>, xfstests <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=sP/K4R02otNkUvOyG4t1TI1+aoxKwfF0e/q/mxSOjkU=; b=xcoeMKg/Nt4Kl8PkWCB/kEVuQ/dowg4ahdOQskG2qhHYck+Lk1/btLXddjYmL9cpeG DUXa9A+G4T4sp8dPv1uOI3cP/pp4gjH1bWX9AcijB+CBHMxjUKJ88Rn5dw8MXZYHRcux kTnyHOwnZRuayEVv+bHqinXX60BeTGMbPxj8253oiTfO1XlXLqw/Zbnv00zG5B98yrhL 9iAcOQiDZh6UgMf4BAR++Gv+Q0o00m1J4yenGGTlaHhhP/h3ZZ9Cy+br0v037AJIh5Qg 7TmF5Jih7uRJ4/Z0fwIyxLUoU18iYA8PIXNYBxneHrgVJpY5SF6OKYib60ZNYHnyPCkX yJ/A==
In-reply-to: <20130412074034.GC30622@dastard>
References: <51678D0D.1070002@xxxxxxxxx> <20130412074034.GC30622@dastard>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 2013å04æ12æ 15:40, Dave Chinner wrote:
On Fri, Apr 12, 2013 at 12:26:53PM +0800, Wang Sheng-Hui wrote:
+TOPDIR = ..
+include $(TOPDIR)/include/builddefs
+TESTS_SUBDIRS = $(shell find . -maxdepth 1 -type d | sed -n -e 's/\.\///gp')

This is much neater:

TESTS_SUBDIRS = $(sort $(dir $(wildcard  $(PWD)/*/)))

Hi Dave,

I introduces Makefile under tests/, which would return to TESTS_SUBDIRS with the
$(dir function. By running find in $(shell, TEST_SUBDIRS will only get the dir 
and no Makefile.



<Prev in Thread] Current Thread [Next in Thread>