xfs
[Top] [All Lists]

xfstests: heads up about coreutils v8.20+ related failures

To: xfs@xxxxxxxxxxx
Subject: xfstests: heads up about coreutils v8.20+ related failures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 11 Apr 2013 19:45:12 +1000
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
Folks,

Debian unstable just transistined to coreutils v8.20 recently, ad
this has caused a bunch of tests to fail due to golden output
mismatches.

A while back, various GNU projects have decided to use the gcc quote
method, which means that the longstanding format of output messages
has changed to what gcc has been using for some time.

This is the typical sort of diff you'll see in a failure:

-mv: cannot move `TEST_DIR/test-mv/ab/aa/' to `TEST_DIR/test-mv/aa': File exists
+mv: cannot move 'TEST_DIR/test-mv/ab/aa/' to 'TEST_DIR/test-mv/aa': File exists

It's subtle, but the difference is `...' vs '...'.(*)

What this means is that we are going to have to add filters to all
the coreutils output in xfstests to convert the quotes to a common
format for the golden output.

I'm not going to get to this in the next couple of weeks (travel to
LF collab summit/LSFMM next week), so someone else might want to
have a look at this in the mean time...

Cheers,

Dave.

(*) Well, it's even more subtle than that, because I've had problems
with GCC quotes for years - they simply don't don't copy-n-paste
very well, even when all terminals and machines are using the same
locale and UTF-8 aware applications:

v8.13
$ LC_ALL=en_AU.UTF-8 mv a /etc
mv: cannot move `a' to `/etc/a': Permission denied

v8.20:
$ LC_ALL=en_AU.UTF-8 mv a /etc
mv: cannot move ¿a¿ to ¿/etc/a¿: Permission denied

Yeah, the quotes from v8.20 didn't paste as quotes. gcc has
displayed this behaviour for years, and now coreutils will behave
the same. Welcome to the wonderful new world of screwed up quotes in
bug reports....
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • xfstests: heads up about coreutils v8.20+ related failures, Dave Chinner <=