Re: [PATCH 14/22] xfs: shortform directory offsets change for dir3 forma

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 14/22] xfs: shortform directory offsets change for dir3 format
From:	Ben Myers <bpm@xxxxxxx>
Date:	Wed, 10 Apr 2013 14:52:49 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1364965892-19623-15-git-send-email-david@xxxxxxxxxxxxx>
References:	<1364965892-19623-1-git-send-email-david@xxxxxxxxxxxxx> <1364965892-19623-15-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Wed, Apr 03, 2013 at 04:11:24PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Because the header size for the CRC enabled directory blocks is
> larger, the offset of the first entry into a directory block is
> different to the dir2 format. The shortform directory stores the
> dirent's offset so that it doesn't change when moving from shortform
> to block form and back again, and hence it needs to take into
> account the different header sizes to maintain the correct offsets.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks great.

-Ben

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/22] xfs: add support for large btree blocks, (continued) [PATCH 02/22] xfs: add support for large btree blocks, Dave Chinner [PATCH 01/22] xfs: increase hexdump output in xfs_corruption_error, Dave Chinner [PATCH 03/22] xfs: add CRC checks to the AGF, Dave Chinner [PATCH 06/22] xfs: add CRC checks for quota blocks, Dave Chinner [PATCH 04/22] xfs: add CRC checks to the AGFL, Dave Chinner [PATCH 12/22] xfs: add CRC checking to dir2 data blocks, Dave Chinner [PATCH 09/22] xfs: add CRC checks to remote symlinks, Dave Chinner [PATCH 07/22] xfs: add version 3 inode format with CRCs, Dave Chinner [PATCH 08/22] xfs: split out symlink code into it's own file., Dave Chinner [PATCH 14/22] xfs: shortform directory offsets change for dir3 format, Dave Chinner Re: [PATCH 14/22] xfs: shortform directory offsets change for dir3 format, Ben Myers <= [PATCH 10/22] xfs: add CRC checks to block format directory blocks, Dave Chinner [PATCH 18/22] xfs: add CRC protection to remote attributes, Dave Chinner Re: [PATCH 18/22] xfs: add CRC protection to remote attributes, Ben Myers Re: [PATCH 18/22] xfs: add CRC protection to remote attributes, Dave Chinner [PATCH 11/22] xfs: add CRC checking to dir2 free blocks, Dave Chinner [PATCH 16/22] xfs: add CRCs to attr leaf blocks, Dave Chinner Re: [PATCH 16/22] xfs: add CRCs to attr leaf blocks, Ben Myers Re: [PATCH 16/22] xfs: add CRCs to attr leaf blocks, Dave Chinner [PATCH V2 16/22] xfs: add CRCs to attr leaf blocks, Dave Chinner [PATCH 22/22] xfs: implement extended feature masks, Dave Chinner

Previous by Date:	Re: [PATCH] xfs: reserve fields in inode for parent ptr and alloc policy, Rich Johnston
Next by Date:	Re: [PATCH] xfs: reserve fields in inode for parent ptr and alloc policy, Mark Tinguely
Previous by Thread:	[PATCH 14/22] xfs: shortform directory offsets change for dir3 format, Dave Chinner
Next by Thread:	[PATCH 10/22] xfs: add CRC checks to block format directory blocks, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]