xfs
[Top] [All Lists]

Re: [PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH]xfs: Remove the obsolete XLOG_CIL_HARD_SPACE_LIMIT() macros
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 08 Apr 2013 16:30:54 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <515CFD42.70109@xxxxxxxxxx>
References: <515CFD42.70109@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 04/03/13 23:10, Jeff Liu wrote:
There is no more users of this Macro, so it's time to kill it dead.

Signed-off-by: Jie Liu<jeff.liu@xxxxxxxxxx>
---
  fs/xfs/xfs_log_priv.h |    1 -
  1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index 16d8d12..b9ea262 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -468,7 +468,6 @@ struct xfs_cil {
   * threshold, yet give us plenty of space for aggregation on large logs.
   */
  #define XLOG_CIL_SPACE_LIMIT(log)     (log->l_logsize>>  3)
-#define XLOG_CIL_HARD_SPACE_LIMIT(log) (3 * (log->l_logsize>>  4))

  /*
   * ticket grant locks, queues and accounting have their own cachlines

Removed in commit:

commit 4c2d542f2e786537db33b613d5199dc6d69a96da
Author: Dave Chinner <david@xxxxxxxxxxxxx>
Date:   Mon Apr 23 17:54:32 2012 +1000

    xfs: Do background CIL flushes via a workqueue

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>