xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfstests generic 310: fix common file path and other cle

To: Eryu Guan <eguan@xxxxxxxxxx>, <zhaohongjiang@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfstests generic 310: fix common file path and other cleanups
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Mon, 8 Apr 2013 09:05:07 -0500
Cc: <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1365331147-15179-3-git-send-email-eguan@xxxxxxxxxx>
References: <1365331147-15179-1-git-send-email-eguan@xxxxxxxxxx> <1365331147-15179-3-git-send-email-eguan@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
Hi Eryu,

Thanks for this cleanup patch. I was going to revert patch "bbaf78c0" which introduced test generic/310 but will wait and see if Zhao will provide more information which could be added to this patch.


On 04/07/2013 05:39 AM, Eryu Guan wrote:
1. add one space between # and test description

The rest of the changes look good, sorry I missed them when I reviewed ;).

2. remove creator/owner info
3. fix common/rc and common/filter path so they can be sourced correctly
4. no need to remove $seq.full cause it's not used(or if verbose output
    is needed, $seqres.full should be used)

Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx>
---
  tests/generic/310 | 12 +++++-------
  1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/tests/generic/310 b/tests/generic/310
index ef51422..35baa23 100644
--- a/tests/generic/310
+++ b/tests/generic/310
@@ -1,8 +1,8 @@
  #! /bin/bash
  # FS QA Test No. 310
  #
-#Check if there are two threads,one keeps calling read() or lseek(), and
-#the other calling readdir(), both on the same directory fd.
+# Check if there are two threads,one keeps calling read() or lseek(), and
+# the other calling readdir(), both on the same directory fd.
  #

Hi Zhao,

I did see both threads running at the same time, but the more I look at this, the more I am a loss as to what this test is doing.

Will you expand this a little please. I should have asked for more justification the first time I reviewed this. Please provide what bug this is testing or what failure/weakness this test exposes. If there is a commit this is related to, please reference it.

Thanks
--Rich

<Prev in Thread] Current Thread [Next in Thread>