xfs
[Top] [All Lists]

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is call

To: Marco Stornelli <marco.stornelli@xxxxxxxxx>
Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Sat, 6 Apr 2013 22:50:33 +0100
Cc: Linux FS Devel <linux-fsdevel@xxxxxxxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxxxx>, Steve French <sfrench@xxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, Matthew Wilcox <matthew@xxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Alasdair G Kergon <agk@xxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <515FF344.8040705@xxxxxxxxx>
References: <515FF344.8040705@xxxxxxxxx>
Sender: Al Viro <viro@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote:
> In every place where sb_start_write was called now we must manage
> the error code and return -EINTR.

Now go and look for callers of mnt_want_write() ;-/  The really
painful one is in do_last(), but kern_path_create() is not much
better; mq_open() would be bad too, had it not been about something
you are not going to freeze anyway...

<Prev in Thread] Current Thread [Next in Thread>